feat(conformance): add data-driven ACP core v1 suite with CI/nightly coverage#130
Merged
osolmaz merged 6 commits intoopenclaw:mainfrom Mar 13, 2026
Merged
Conversation
Contributor
|
great idea, will see if it needs rework and land if not |
Contributor
|
Landed via temp rebase onto main.
Thanks @lynnzc! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a protocol-level ACP conformance suite for ACPX with a data-driven runner and CI/nightly coverage.
This establishes a stable, deterministic baseline for core ACP behavior and makes it straightforward to run the same profile against real adapters via
--agent-command.Why
ACPX currently relies on integration tests and manual checks to catch ACP regressions. What was missing is a protocol-focused contract layer that is deterministic, adapter-agnostic, and easy to extend.
This PR adds that missing layer.
Changes
conformance/spec/v1.md(normative v1 contract)conformance/profiles/acp-core-v1.json(required-case profile)conformance/cases/*.jsonconformance/runner/run.tsstepsexecution (new_session,prompt,prompt_background,await_background,cancel,sleep)checksevaluationpermission_modeoverride supportconformance/README.mdusage and model docsconformance:runscript inpackage.json.github/workflows/ci.yml.github/workflows/conformance-nightly.ymlValidation
Local verification completed:
pnpm run conformance:run(20/20 passed)pnpm run typecheckpnpm run lintpnpm run check:docsScope
Included:
test/mock-agent.tsNot included in this PR: